Add surface field for highways #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep surface field from OSM on highways, generalize it to two values: "paved" and "unpaved". This is a fix for openmaptiles#389 and a partial fix for openmaptiles#422.
|
I just tested this. Is it just me or are there not many roads that have the |
|
From my experience, surface is not often mapped in urban areas where there is asphalt everywhere and contributors are not very eager to add the same surface again and again. You can check with an Overpass query such as https://overpass-turbo.eu/s/F9o. |
|
I've just updated the tag lists according to Wiki https://wiki.openstreetmap.org/wiki/Key:surface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR keeps surface field from OSM on highways, generalize it to two values:
"paved" and "unpaved".
This is a fix for #389 and a partial fix for #422.
Here are some benchmarks (for tiles up to zoom 14):
Albania
Total tile size with
masterbranch: 102MB.Size increase with this PR: 60kB.
Czech Republic
Total tile size with
masterbranch: 519MB.Size increase with this PR: 1.19MB.
Switzerland
Total tile size with
masterbranch: 268MB.Size increase with this PR: 1.25MB.
Best,