Add rstats templates #136
Open
Add rstats templates #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Solymos <psolymos@gmail.com>
|
Hi Peter, Is this template multi-arch? Alex |
|
Signed-off-by: Peter Solymos <psolymos@gmail.com>
|
Thanks @alexellis for having a look. I haven't tested multi-arch with these templates. Should I try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Solymos psolymos@gmail.com
I created R/rstats templates using different HTTP frameworks and base images. I've decided to add the following 2 to the
templates.jsonfile of the store repository for the following reason:rstats-minimal: vanilla R + classic watchdog on Alpine base image, should be suitable as the smallest build for text/JSON based functions not needing additional R functionalityrstats-base-plumber: R with plumber package installed + of-watchdog on Debian base image, this is the most versatile, plumber is mature with great community support and easy to add serializers/parsers through code annotation.The https://github.com/analythium/openfaas-rstats-templates repository has other templates that might not be all suitable for mainstream consumption. The repo also has detailed documentation and an increasing number of examples.
R templates was discussed previously on Slack and offline, thanks for the great feedback.
I opened the related #114 request previously.