[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new blog to community resources. #1561

Closed
wants to merge 2 commits into from
Closed

Add new blog to community resources. #1561

wants to merge 2 commits into from

Conversation

yankeexe
Copy link
Contributor
@yankeexe yankeexe commented Aug 15, 2020 •
edited
Loading

Add Deploy your Serverless Python function locally with OpenFaas in Kubernetes blog to community.md.

Description

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link
derek bot commented Aug 15, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Aug 15, 2020
@derek derek bot removed the no-dco label Aug 15, 2020
@yankeexe
Update typo under definitions
6e2e158 
Fixes openfaas#1578

Change FunctionDefintion to FunctionDefinition

Signed-off-by: yankeexe <yankee.exe@gmail.com>
alexellis
alexellis previously approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member
@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis
Copy link
Member

You'll need to rebase this.

@alexellis
Copy link
Member

@yankeexe please see my comment above.

@derek
Copy link
derek bot commented Nov 11, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Nov 11, 2020
@yankeexe
Merge branch 'master' of github.com:openfaas/faas
809a2f9 
Signed-off-by: yankeexe <yankee.exe@gmail.com>
@derek derek bot removed the no-dco label Nov 11, 2020
@yankeexe
Copy link
Contributor Author

@alexellis Can you check now? I tried rebasing, but it says my branch is up to date.

@alexellis alexellis closed this Nov 17, 2020
@alexellis
Copy link
Member

Closing as I see no changes. Feel free to do a new PR if you have new posts to list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis left review comments

Assignees
No one assigned
Labels
new-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yankeexe @alexellis