docker/docker#27484-check if sysctls are used in host network mode. #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @crosbymichael |
7a30894 to
2a823be
Compare
|
Sorry about it, I have added it. |
2a823be to
1144d8a
Compare
|
LGTM |
mrunalp
reviewed
Oct 21, 2016
| if err != nil { | ||
| return fmt.Errorf("read soft link %q error", path) | ||
| } | ||
| if destOfContainer == destOfCurrentProcess { |
There was a problem hiding this comment.
Can we add a helper method to compare namespace links?
There was a problem hiding this comment.
OK, the logic is a little complex.
c307ab2 to
3ce3ea5
Compare
|
PTAL |
cyphar
reviewed
Oct 22, 2016
| return fmt.Errorf("sysctl %q is not allowed in the hosts network namespace", s) | ||
| } | ||
| if config.Namespaces.PathOf(configs.NEWNET) != "" { |
There was a problem hiding this comment.
You can do this:
if path := config.Namespaces.PathOf(configs.NEWNET); path != "" {
if err := checkHostNs(s, path); err != nil {
return err
}
}
Signed-off-by: Ce Gao <ce.gao@outlook.com>
3ce3ea5 to
bc84f83
Compare
Signed-off-by: Ce Gao <ce.gao@outlook.com>
|
LGTM |
|
PTAL |
|
LGTM |
|
@gaocegege I was testing an update to |
cyphar
reviewed
Oct 26, 2016
| @@ -125,14 +125,36 @@ func (v *ConfigValidator) sysctl(config *configs.Config) error { | |||
| } | |||
| } | |||
| if strings.HasPrefix(s, "net.") { | |||
| if config.Namespaces.Contains(configs.NEWNET) { | |||
| continue | |||
There was a problem hiding this comment.
Ah yeah, this is a bug. I'll make a PR to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref moby/moby#27484
Signed-off-by: Ce Gao ce.gao@outlook.com