pdf2john.py: fix compatibility with current pyhanko versions #5790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improved resilience with non-pdf files and unencrypted pdf files
solardiz
reviewed
Jun 20, 2025
| print("pyhanko is missing, run 'pip install --user pyhanko==0.20.1' to install it!") | ||
| exit(1) | ||
| print("pyhanko is missing, run 'pip install --user pyhanko' to install it!", file=sys.stderr) | ||
| sys.exit(1) |
There was a problem hiding this comment.
BTW, we also have uses of plain exit in a few other scripts:
apop2john.py: exit(1)
apop2john.py: exit(1)
authenticator2john.py: exit(1)
authenticator2john.py: exit(1)
bestcryptve2john.py: exit(0)
bitlocker2john.py: exit()
kdcdump2john.py: exit()
mosquitto2john.py: exit(1)
There was a problem hiding this comment.
I could fix them. But these are rather minor linting issues and many scripts produce several linting issues. Too many to go over everything in every script. So tackling exactly the exit() issue would feel a bit random and not very important.
solardiz
approved these changes
Jun 20, 2025
|
Thank you @exploide! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5788
The actual change for compatibility was easy. But while I was at it, I improved the script's resilience with non-pdf files and unencrypted pdf files.
Produces the same output as before on
john-samples/**.pdf.