8000 [Fix] Fix typos and bugs. by zytx121 · Pull Request #3 · open-mmlab/mmrotate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Fix] Fix typos and bugs. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2022
Merged

[Fix] Fix typos and bugs. #3

merged 2 commits into from
Feb 18, 2022

Conversation

zytx121
Copy link
Collaborator
@zytx121 zytx121 commented Feb 18, 2022
  • Add CITATION.cff
  • Refact import BACKBONES -> import MODELS in mmrotate/models/builder.py
  • Fix getting_started.md and download link bugs
  • Fix typo: rotation detection -> rotated detection in docs
  • Update bibtex.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 requested a review from yangxue0827 February 18, 2022 05:56
yangxue0827
yangxue0827 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator
@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 self-assigned this Feb 18, 2022
yangxue0827
yangxue0827 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator
@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 requested a review from ZwwWayne February 18, 2022 06:28
ZwwWayne
ZwwWayne reviewed Feb 18, 2022
View reviewed changes
ZwwWayne
ZwwWayne reviewed Feb 18, 2022
View reviewed changes
@zytx121 zytx121 requested a review from ZwwWayne February 18, 2022 07:10
@ZwwWayne ZwwWayne merged commit 6519a36 into open-mmlab:main Feb 18, 2022
@zytx121 zytx121 mentioned this pull request Mar 10, 2022
Merged
@xiaoyihit xiaoyihit mentioned this pull request Jun 7, 2022
Closed
@JinqingZhengTju JinqingZhengTju mentioned this pull request Oct 29, 2022
Closed
@pangyanhua pangyanhua mentioned this pull request Nov 10, 2022
Closed
3 tasks
@sltlls sltlls mentioned this pull request Nov 13, 2022
Closed
3 tasks
@ToneZe ToneZe mentioned this pull request Oct 14, 2023
Closed
@2597883929 2597883929 mentioned this pull request Oct 31, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangxue0827 yangxue0827 yangxue0827 approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees

@zytx121 zytx121

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zytx121 @yangxue0827 @ZwwWayne
0