8000 add dockerfile by sanbuphy · Pull Request #9659 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add dockerfile #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2023
Merged

add dockerfile #9659

merged 5 commits into from
Jan 29, 2023

Conversation

sanbuphy
Copy link
Contributor
@sanbuphy sanbuphy commented Jan 23, 2023 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Help china users build docker more effectively.

Modification

fix the nvidia-GPG key error and python -i image source.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

ZwwWayne
ZwwWayne reviewed Jan 28, 2023
View reviewed changes
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Jan 28, 2023
@ZwwWayne
Copy link
Collaborator

Hi @sanbuphy ,
Thanks for your kind contribution. Would you like to fix the lint issue so we can merge this PR?
The details can be found by clicking the item of lint check as shown below
image

If the lint is fixed and the updated dockerfile is verified, we can merge this PR.

@sanbuphy
Copy link
Contributor Author
sanbuphy commented Jan 28, 2023 •
edited
Loading

Hi @sanbuphy , Thanks for your kind contribution. Would you like to fix the lint issue so we can merge this PR? The details can be found by clicking the item of lint check as shown below image

If the lint is fixed and the updated dockerfile is verified, we can merge this PR.

Hello @ZwwWayne , I have solved all problem and i have already try to build the dockerfile on my computer.
image

image

@ZwwWayne
Copy link
Collaborator

Great ! Thanks @sanbuphy ,
I find that the other two files in serve_cn is unnecessary. Is there anyway we can delete these two files and only keep the updated Dockerfile with acceleration in China?

@sanbuphy
Copy link
Contributor Author
sanbuphy commented Jan 28, 2023 •
edited
Loading

Great ! Thanks @sanbuphy , I find that the other two files in serve_cn is unnecessary. Is there anyway we can delete these two files and only keep the updated Dockerfile with acceleration in China?

@ZwwWayne Yes, get it . I think you are right because we just use these two files in serve and we don't need to create the same files in serve_cn.

@ZwwWayne ZwwWayne merged commit 8468f1e into open-mmlab:dev-3.x Jan 29, 2023
@sanbuphy sanbuphy deleted the dockerbranch branch January 29, 2023 08:10
@sanbuphy sanbuphy restored the dockerbranch branch January 29, 2023 08:10
@sanbuphy sanbuphy deleted the dockerbranch branch January 29, 2023 08:10
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@sanbuphy @yumion
[Enhance]: add torchserve dockerfile that is faster in China (open-mm…
40fd778 
…lab#9659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne left review comments

Assignees

@Czm369 Czm369

Labels
None yet
Projects
None yet
Milestone
3.0.0rc7
Development

Successfully merging this pull request may close these issues.
3 participants
@sanbuphy @ZwwWayne @Czm369
0