8000 [Fix] Add typehint for `DarknetBottleneck` by PeterH0323 · Pull Request #9591 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Fix] Add typehint for DarknetBottleneck #9591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 10, 2023
Merged

[Fix] Add typehint for DarknetBottleneck #9591

merged 5 commits into from
Jan 10, 2023

Conversation

PeterH0323
Copy link
Contributor

Motivation

Add typehint for DarknetBottleneck

Modification

mmdetection/mmdet/models/layers/csp_layer.py

@ZwwWayne ZwwWayne requested a review from RangiLyu January 9, 2023 04:43
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Jan 9, 2023
BIGWangYuDong
BIGWangYuDong reviewed Jan 9, 2023
View reviewed changes
@PeterH0323 PeterH0323 requested review from BIGWangYuDong and removed request for RangiLyu January 9, 2023 05:58
BIGWangYuDong
BIGWangYuDong reviewed Jan 9, 2023
View reviewed changes
@BIGWangYuDong
Copy link
Collaborator
BIGWangYuDong commented Jan 9, 2023 •
edited
Loading

LGTM, thanks for your contribution! Please change the PR tile to the CodeCamp format! Also, it is suggested to finish CodeCamp tasks in this single PR.

@PeterH0323
Copy link
Contributor Author
PeterH0323 commented Jan 9, 2023 •
edited
Loading

Hi @BIGWangYuDong ，我不是 CodeCamp 中 mmdet typehint 的报名成员，我正在为 MMYOLO 提交新算法的开发过程中发现了这个问题，顺手修复提的这个 PR 😄

BIGWangYuDong
BIGWangYuDong approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator
@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 6e9cfd4 into open-mmlab:dev-3.x Jan 10, 2023
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@PeterH0323 @yumion
[Fix] Add typehint for DarknetBottleneck (open-mmlab#9591)
f0fc843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BIGWangYuDong BIGWangYuDong BIGWangYuDong approved these changes

Assignees

@ZwwWayne ZwwWayne

Labels
None yet
Projects
None yet
Milestone
3.0.0rc7
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterH0323 @BIGWangYuDong @ZwwWayne
0