8000 [Refactor] Refactor `setup.cfg` by Xiangxu-0103 · Pull Request #9370 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Refactor] Refactor setup.cfg #9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

[Refactor] Refactor setup.cfg #9370

merged 1 commit into from
Nov 29, 2022

Conversation

Xiangxu-0103
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

8000
@ZwwWayne
Copy link
Collaborator

Hi @Xiangxu-0103 ,
Thanks for your kind PR. Would you elaborate on why the modification is necessary?

@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 23, 2022
@Xiangxu-0103
Copy link
Contributor Author
Xiangxu-0103 commented Nov 23, 2022 •
edited
Loading

Hi @Xiangxu-0103 , Thanks for your kind PR. Would you elaborate on why the modification is necessary?

Hi @ZwwWayne , From my perspective, I think it's better to refactor it according to the order of letters, which is consistency with the import rule.

@ZwwWayne ZwwWayne merged commit 463cd18 into open-mmlab:dev-3.x Nov 29, 2022
@Xiangxu-0103 Xiangxu-0103 deleted the refactor_setup branch November 29, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhaAndroid hhaAndroid hhaAndroid approved these changes

Assignees

@hhaAndroid hhaAndroid

Labels
None yet
Projects
None yet
Milestone
3.0.0rc5
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiangxu-0103 @ZwwWayne @hhaAndroid
0