8000 add yolof init_cfg by twmht · Pull Request #8243 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add yolof init_cfg #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023
Merged

add yolof init_cfg #8243

merged 1 commit into from
Jan 29, 2023

Conversation

twmht
Copy link
Contributor
@twmht twmht commented Jun 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Can't init yolof detector

Modification

Add init_cfg to yolof like other detectors

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  • The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link
CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@twmht twmht closed this Jun 23, 2022
@twmht twmht reopened this Jun 23, 2022
@ZwwWayne ZwwWayne requested a review from hhaAndroid June 25, 2022 03:11
@ZwwWayne ZwwWayne changed the base branch from master to dev June 25, 2022 03:11
@codecov
Copy link
codecov bot commented Jun 25, 2022

Codecov Report

Base: 64.17% // Head: 64.19% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (eb6df23) compared to base (ca11860).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8243      +/-   ##
==========================================
+ Coverage   64.17%   64.19%   +0.02%     
==========================================
  Files         361      361              
  Lines       29525    29525              
  Branches     5019     5019              
==========================================
+ Hits        18947    18955       +8     
+ Misses       9575     9565      -10     
- Partials     1003     1005       +2     
Flag Coverage Δ
unittests 64.17% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/detectors/yolof.py 83.33% <ø> (ø)
mmdet/models/dense_heads/corner_head.py 69.72% <0.00%> (+1.38%) ⬆️
mmdet/utils/misc.py 64.10% <0.00%> (+2.56%) ⬆️
mmdet/models/detectors/cornernet.py 100.00% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit ea29a1e into open-mmlab:dev Jan 29, 2023
thmegy pushed a commit to thmegy/mmdetection that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0