8000 [Fix] avoid get_local_path bc-breaking by BIGWangYuDong · Pull Request #6719 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Fix] avoid get_local_path bc-breaking #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 22, 2021

Conversation

BIGWangYuDong
Copy link
Collaborator

No description provided.

@codecov
Copy link
codecov bot commented Dec 8, 2021

Codecov Report

Merging #6719 (234c24e) into master (f08548b) will decrease coverage by 0.02%.
The diff coverage is 22.22%.

❗ Current head 234c24e differs from pull request most recent head 16628c2. Consider uploading reports for the commit 16628c2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6719      +/-   ##
==========================================
- Coverage   61.97%   61.95%   -0.03%     
==========================================
  Files         322      322              
  Lines       25678    25683       +5     
  Branches     4348     4350       +2     
==========================================
- Hits        15915    15912       -3     
- Misses       8923     8929       +6     
- Partials      840      842       +2     
Flag Coverage Δ
unittests 61.93% <22.22%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/custom.py 64.08% <22.22%> (-1.83%) ⬇️
mmdet/models/dense_heads/base_dense_head.py 89.47% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08548b...16628c2. Read the comment docs.

@hhaAndroid
Copy link
Collaborator

@BIGWangYuDong Please fix lint.

@BIGWangYuDong
Copy link
Collaborator Author

@BIGWangYuDong Please fix lint.

Done

@ZwwWayne ZwwWayne merged commit df212e7 into open-mmlab:master Dec 22, 2021
@AronLin AronLin mentioned this pull request Dec 27, 2021
@BIGWangYuDong BIGWangYuDong deleted the fix_fileclient branch March 17, 2022 01:33
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
* [Fix] avoid get_local_path bc-breaking

* avoid mmcv.FileClient.get_local_path bc-breaking

* avoid mmcv.FileClient.get_local_path bc-breaking

* avoid mmcv.FileClient.get_local_path bc-breaking

* Update custom.py

* Update custom.py

* fix lint
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* [Fix] avoid get_local_path bc-breaking

* avoid mmcv.FileClient.get_local_path bc-breaking

* avoid mmcv.FileClient.get_local_path bc-breaking

* avoid mmcv.FileClient.get_local_path bc-breaking

* Update custom.py

* Update custom.py

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0