8000 competition-centernetv2 by huimlight · Pull Request #5861 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

competition-centernetv2 #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

huimlight
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Learn Centernetv2, learn MMDET.

Modification

Code: we add detector in mmdet/models/detectors/centernetv2.py.

Code: we add config in configs/centernetv2/centernet2.py.

Code: we add centernet_head in mmdet/dense_heads/centernet_headv2.py.

Code: we add hm_binary_focal_loss in mmdet/losses/hm_binary_focal_loss.py.

Code: we modify mmdet/roi_heads/cascade_roi_head.py, add the super parameter add_agnostic_score to Control whether the first stage score.This hyperparameter does not affect the use of other configuration files

Code: we modify mmdet/bbox_head/bbox_head.py, add the super parameter add_agnostic_score to Control Whether to use softmax.This hyperparameter does not affect the use of other configuration files

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link
CLAassistant commented Aug 11, 2021

CLA assistant check
All committers have signed the CLA.

@LMerCy
Copy link
LMerCy commented Aug 30, 2021

@huimlight So you don't multiply rpn score with rcnn score when training?

@huimlight
Copy link
Author

@huimlight So you don't multiply rpn score with rcnn score when training?

no, I multiply. This code in cascade_roi_head.py

@FDInSky
Copy link
FDInSky commented Nov 25, 2021

很棒的工作,什么时候可以合入啊?

@ZwwWayne ZwwWayne requested review from jbwang1997 and removed request for jbwang1997 February 16, 2022 02:05
@wusize
Copy link
wusize commented Mar 26, 2022

@huimlight So you don't multiply rpn score with rcnn score when training?

It's not multiplied in training based on what I see. In fact, the rpn score is not used to calculate rcnn loss in the official implemenation either.

def _init_predictor(self):
"""Initialize predictor layers of the head."""
self.conv_reg = nn.Conv2d(self.feat_channels, 4, 3, padding=1)
self.agn_hm = nn.Conv2d(self.in_channels, 1, 3, stride=1, padding=1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems did not use num_classes? should we set num_classes=1 in config file?

8000
num_points * 4.
agn_hms (list[Tensor]): Box scores for each scale level, \
each is a 4D-tensor, the channel number is \
num_points * num_classes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the output shape, is num_points * num_classes or num_points * 1?

@ZwwWayne
Copy link
Collaborator

closed as it has been continued in #9566

@ZwwWayne ZwwWayne closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0