8000 [Fix]: fix panoptic dependency issue when publishing to pypi by ZwwWayne · Pull Request #5781 · open-mmlab/mmdetection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Fix]: fix panoptic dependency issue when publishing to pypi #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2021
Merged

[Fix]: fix panoptic dependency issue when publishing to pypi #5781

merged 2 commits into from
Aug 3, 2021

Conversation

ZwwWayne
Copy link
Collaborator
@ZwwWayne ZwwWayne commented Aug 3, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When publishing this package to PyPi, PyPi will reject this package because it includes the URL of panopticapi outside PyPi.

Modification

Remove panopticapi from the runtime.txt and add documentation to tell users to manually install panoptic API if they want to use it.

BC-breaking (Optional)

N/A

Use cases (Optional)

N/A

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne requested review from AronLin and hhaAndroid August 3, 2021 13:46
AronLin
AronLin reviewed Aug 3, 2021
View reviewed changes
8000
@codecov
Copy link
codecov bot commented Aug 3, 2021

Codecov Report

Merging #5781 (f1b8a17) into master (90e0ec7) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head f1b8a17 differs from pull request most recent head 9ec0557. Consider uploading reports for the commit 9ec0557 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5781      +/-   ##
==========================================
- Coverage   66.46%   66.41%   -0.06%     
==========================================
  Files         281      281              
  Lines       22019    22016       -3     
  Branches     3659     3659              
==========================================
- Hits        14636    14621      -15     
- Misses       6632     6636       +4     
- Partials      751      759       +8
Flag Coverage Δ
unittests 66.41% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/dense_test_mixins.py 41.02% <0.00%> (-2.57%) ⬇️
mmdet/models/roi_heads/test_mixins.py 72.34% <0.00%> (-2.13%) ⬇️
mmdet/datasets/pipelines/transforms.py 72.56% <0.00%> (-0.92%) ⬇️
mmdet/datasets/custom.py 63.37% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e0ec7...9ec0557. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 604bfe9 into open-mmlab:master Aug 3, 2021
@GT9505 GT9505 mentioned this pull request Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AronLin AronLin AronLin approved these changes

@hhaAndroid hhaAndroid Awaiting requested review from hhaAndroid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZwwWayne @AronLin
0