reusing resource ids, needs further testing #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just cleaning up old PRs...this is interesting. The concern of the dataset, we could also UUID based on dataset_type and owner_org ID. So that the Recombinant dataset IDs would also always be the same? |
|
That's a good idea too, just need to check if a dataset with that id exists in a deleted state and call package_update instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can force resource ids to the same values on all sites, and when recreating datasets. It's certainly nice when we need to make major changes to the schema to not also break ids clients are using.
What I'm not sure of is how this interacts with vdm when we delete a resource that belonged to one dataset then re-create it attached to a different dataset. Seems dangerous.