Expunged code using the GNU Scientific Library from CAMP. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code violates the terms of the GNU Public License, since CAMP uses a non-GPL license, which is disallowed in ANY distributed code that calls GPL-licensed code. I've gone ahead and removed it.
jtgasparik
added a commit
to jtgasparik/camp_
that referenced
this pull request
Feb 18, 2025
* Expunged code using the GNU Scientific Library from CAMP. (open-atmos#25) * Expunged code using the GNU Scientific Library from CAMP. This code violates the terms of the GNU Public License, since CAMP uses a non-GPL license, which is disallowed in ANY distributed code that calls GPL-licensed code. I've gone ahead and removed it. * Adding make as an explicit dependency in Dockerfiles. * Uses the standard C bool type, which is defined in stdbool.h. (open-atmos#26) * Updates to work with new intel compiler (open-atmos#29) update to work with new intel compiler * Simpol multiple layers (open-atmos#30) * addition of is_at_surface flag to num_phase_instances function * testing partmc coupling * testing * fixed num_phase_instances function, now passes * fixed function and added test * one more test * testing * reverting change * changes to phase_id function * deleted duplicate num_instances variable * testing SIMPOL reaction with multiple layers added to the json - currently failing * update unique names function to have is_at_surface flag * remote diagnostic output * added test for unique_name function * ive broken the SIMPOL rxn again by adding layers * adding mass * minor changes to SIMPOl test * fix to write statement - still not passing tests * added tests for phase_ids function to single particle * test added for phase id for modal/binned rep * added second particle to test suite for single particle c test - in progress * adding unit tests to single particle c functions with multiple particles and different layers -- in progress * adding second particle to single particle c tests -- in progress and failing * adding another test particle and phase to single particle test aero rep test -- in progress * testing the same phase in a different particle works. testing a different phase in a different particle is in-progress * testing differnt particles and different layers * second test phase added -- failing for test phase 1 and 3 * print statements to repo * modified print statements * update calls to aero phase functions (#9) * MULTIPLE LAYERS WORK - fix to tests * SIMPOL with two layers and some mass in second layer * added test to SIMPOL * added HL test with multiple layers, plus minor SIMPOL test changes * one edit * testing HL with mass in layer 2 * test from new laptop and fix to small typo * another test and fix to typo * Update src/aero_rep_data.F90 Co-authored-by: Matt Dawson <mattldawson@gmail.com> * Update src/aero_reps/aero_rep_single_particle.F90 Co-authored-by: Matt Dawson <mattldawson@gmail.com> * resolving comment * fixes to PR * Update src/aero_reps/aero_rep_single_particle.F90 Co-authored-by: Matt Dawson <mattldawson@gmail.com> --------- Co-authored-by: Matt Dawson <mattdawson@ucar.edu> Co-authored-by: Matt Dawson <mattldawson@gmail.com> --------- Co-authored-by: Jeffrey N. Johnson <jeff@cohere-llc.com> Co-authored-by: Matt Dawson <mattdawson@ucar.edu> Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code violates the terms of the GNU Public License, since CAMP uses a non-GPL license, which is disallowed in ANY distributed code that calls GPL-licensed code. I've gone ahead and removed it.