8000 Fix typo in `--clean-obo` option values. by gouttegd · Pull Request #1253 · ontodev/robot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typo in --clean-obo option values. #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

Fix typo in --clean-obo option values. #1253

merged 1 commit into from
May 10, 2025

Conversation

gouttegd
Copy link
Contributor
  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

This PR fixes an unfortunate typo that has been introduced in #1236. The option to forcibly remove axioms that cannot be represented in OBO format is supposed to be --clean-obo drop-untranslatable-axioms (that’s what the documentation says), but the code that handles the --clean-obo values expects drop-unstranslatable-axioms -- note the added s.

Sorry for not having caught that sooner. It’d be nice if it could be fixed before the upcoming 1.10 release, so that the drop-unstranslatable-axioms variant is never actually used by anyone.

@gouttegd
Fix typo in --clean-obo option values.
a2b46ae 
The option to forcibly remove axioms that cannot be represented in OBO
format is supposed to be called `--clean-obo drop-untranslatable-axioms`
(that's what the documentation says), but the code that handles the
`--clean-obo` values expects `drop-unstranslatable-axioms` -- note the
added `s`.
@gouttegd gouttegd self-assigned this May 10, 2025
jamesaoverton
jamesaoverton approved these changes May 10, 2025
View reviewed changes
Copy link
Member
@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to catch that!

@jamesaoverton jamesaoverton merged commit 8bf3a4a into ontodev:master May 10, 2025
3 checks passed
@gouttegd gouttegd deleted the fix-clean-obo-typo branch May 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesaoverton jamesaoverton jamesaoverton approved these changes

Assignees

@gouttegd gouttegd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouttegd @jamesaoverton
0