WIP: Introduce protolint for linting protobuf files #6758
Conversation
This file contains hidden o
8000
r bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6758 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 509 509
Lines 32515 32515
Branches 3057 3057
=======================================
Hits 18356 18356
Misses 13334 13334
Partials 825 825 ☔ View full report in Codecov by Sentry. |
|
Looks like the tool is available on pypi https://github.com/yoheimuta/protolint?tab=readme-ov-file#within-python-projects I recommend it is added to lintrunner adapters for a unified linting experience |
Margen67
reviewed
Mar 16, 2025
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Go (for Protolint) | ||
| uses: actions/setup-go@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-go@v2 | |
| uses: actions/setup-go@v5 |
69D4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context