8000 update auto_update_doc and create sdist_test.yml by andife · Pull Request #6723 · onnx/onnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update auto_update_doc and create sdist_test.yml #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Feb 26, 2025
Merged

update auto_update_doc and create sdist_test.yml #6723

merged 34 commits into from
Feb 26, 2025

Conversation

andife
Copy link
Member
@andife andife commented Feb 21, 2025

Description

Motivation and Context

@andife
Create sdist_test.yml
52ce575 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife requested a review from a team as a code owner February 21, 2025 14:22
@andife
Update sdist_test.yml 8000
bda58cf 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@codecov Codecov
Copy link
codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.13%. Comparing base (b7a0055) to head (7103a28).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6723   +/-   ##
=======================================
  Coverage   57.13%   57.13%           
=======================================
  Files         507      507           
  Lines       31927    31927           
  Branches     3040     3040           
=======================================
  Hits        18240    18240           
  Misses      12864    12864           
  Partials      823      823

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andife
Update sdist_test.yml
b3bc47c 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
1f5adc0 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
c4103da 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
35d5eac 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Copy link
Member Author
andife commented Feb 21, 2025

@justinchuby

@andife andife closed this Feb 22, 2025
@andife andife added the auto update doc Generate md/proto files automatically using the CI pipeline label Feb 22, 2025
@andife andife reopened this Feb 22, 2025
@andife
Merge branch 'main' into andife-patch-10
bfcaf9a
@andife
add protobuf install
117b99a 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update auto_update_doc.yml
090b344 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@cyyever
Copy link
Contributor
cyyever commented Feb 23, 2025

We should downgrade protobuf to 3.21.12 on Ubuntu?

@andife andife changed the title Create sdist_test.yml update auto_update_doc and create sdist_test.yml Feb 24, 2025
@andife
Update auto_update_doc.yml
060e47e 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
eb8d7ef 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife added auto update doc Generate md/proto files automatically using the CI pipeline and removed auto update doc Generate md/proto files automatically using the CI pipeline labels Feb 24, 2025
@andife
Update auto_update_doc.yml
ad03b70 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update auto_update_doc.yml
d2ca991 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
627d27f 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
cef0be7 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
aca8cbd 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Copy link
Member Author
andife commented Feb 24, 2025

We should downgrade protobuf to 3.21.12 on Ubuntu?

Could we use the following? Stay at v4? I would prefer to offer corresponding docs for the different mainstream OSs

wget https://github.com/protocolbuffers/protobuf/releases/download/v25.1/protoc-25.1-linux-x86_64.zip
unzip protoc-25.1-linux-x86_64.zip -d protoc

@andife
Update sdist_test.yml
b3d8e3b 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
17ccf18 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
9817dcf 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife added 10 commits February 25, 2025 10:29
@andife
Merge branch 'main' into andife-patch-10
24dea4c
@andife
Update sdist_test.yml
9dfc900 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
47ce5f9 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
adf17da 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
a0fca17 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update auto_update_doc.yml
68844a4 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
5fd00cd 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update auto_update_doc.yml
4fb8278 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update sdist_test.yml
d6db5cc 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Update auto_update_doc.yml
79df4ed 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife requested a review from justinchuby February 25, 2025 15:10
@andife
Copy link
Member Author
andife commented Feb 25, 2025

@cyyever Why should it be a problem using requirements-release.txt? I use it here: https://github.com/onnx/onnx/pull/6723/files#diff-d16536ab288a08f6a52509f2abac6c7680441a7e3978f9516c61391eb0263b62 => and there the process works

For me it would be ok to generally use the requirements.txt in the first step.

@andife
Update auto_update_doc.yml
e5074b8 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@cyyever
Copy link
Contributor
cyyever commented Feb 25, 2025 •
edited
Loading

@andife It works because

         python onnx/defs/gen_doc.py
          python onnx/gen_proto.py -l
          python onnx/gen_proto.py -l --ml
          python onnx/backend/test/stat_coverage.py
          python onnx/backend/test/cmd_tools.py generate-data --diff

These python files don't import protobuf runtime?

@andife
Update auto_update_doc.yml
18d3c38 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Merge branch 'main' into andife-patch-10
48019d9
@andife
Update auto_update_doc.yml
7103a28 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife mentioned this pull request Feb 26, 2025
Open
@andife andife added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 3d5acaf Feb 26, 2025
41 of 42 checks passed
@andife andife deleted the andife-patch-10 branch February 26, 2025 17:09
@botantony botantony mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyyever cyyever cyyever left review comments

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
auto update doc Generate md/proto files automatically using the CI pipeline
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andife @cyyever @justinchuby
0