8000 Support Python 3.12 by isdanni · Pull Request #5743 · onnx/onnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support Python 3.12 #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jan 23, 2024
Merged

Support Python 3.12 #5743

merged 32 commits into from
Jan 23, 2024

Conversation

isdanni
Copy link
Contributor
@isdanni isdanni commented Nov 9, 2023

Description

Close #5680

Motivation and Context

  • Add Python 3.12 support.

@isdanni isdanni requested a review from a team as a code owner November 9, 2023 01:15
@justinchuby justinchuby added topic: build Issues related to ONNX builds and packages run release CIs Use this label to trigger release tests in CI labels Nov 9, 2023
@justinchuby
Copy link
Contributor

Thank you so much! Could you also enable one for the CI pipeline:

onnx/.azure-pipelines/Linux-CI.yml

Line 40 in 2cf3749

protobuf_type: 'Internal'
.

something like this should do

      py312-internal-protobuf:
        python.version: '3.12'
        onnx_ml: 1
        build_type: 'Release'
        documentation: 0
        protobuf_type: 'Internal'

@justinchuby
Copy link
Contributor
justinchuby commented Nov 9, 2023 •
edited
Loading

Looks like protobuf 3.12 supported was just added :) We may need to wait on this

protocolbuffers/protobuf#14664
protocolbuffers/protobuf#14281

@codecov Codecov
Copy link
codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae749f3) 56.45% compared to head (93ebe9f) 56.45%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5743   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files         504      504           
  Lines       29872    29872           
  Branches     4489     4489           
=======================================
  Hits        16863    16863           
+ Misses      12192    12191    -1     
- Partials      817      818    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isdanni
Support Python 3.12
ec2ec72 
Signed-off-by: isdanni <leedanni@gmail.com>
@justinchuby
Merge branch 'main' into py-312-support
ab35498
@justinchuby
Update settings.json
1fec5b2 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update requirements-release.txt
e9a2cf2 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_mac.yml
9ac8855 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_aarch64.yml
8c1ec5a 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_x86_64.yml
b6d1594 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_win.yml
ac74d93 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby self-assigned this Dec 16, 2023
@justinchuby justinchuby added this to the 1.16 milestone Dec 16, 2023
@justinchuby
Update requirements-release.txt
5d4d89f 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Create requirements-min.txt
ad81533 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_mac.yml
a5cdaed 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_x86_64.yml
0490a70 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_aarch64.yml
1a25c8b 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_win.yml
4a05872 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Apply suggestions from code review
d948474 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update requirements-min.txt
a05d6ff 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update entrypoint.sh
ab28893 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update entrypoint.sh
8f9c532 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update entrypoint.sh
56bc984 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update requirements-min.txt
26d79eb 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Copy link
Contributor

Looks like pypa's docker file doesn't have python3.12 install in the expected path. Not sure why yet

@isdanni
Copy link
Contributor Author
isdanni commented Jan 14, 2024

Looks like pypa's docker file doesn't have python3.12 install in the expected path. Not sure why yet

Marking this as draft at the moment so it won't fail weekly CI. Will reopen once the package issue is resolved.

@isdanni isdanni marked this pull request as draft January 14, 2024 22:19
isdanni and others added 9 commits January 14, 2024 17:20
@isdanni
Merge branch 'main' into py-312-support
bfcf898
@justinchuby
Merge branch 'main' into py-312-support
f55da9a
@justinchuby
Update entrypoint.sh
1356991 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update entrypoint.sh
bb11e71 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_x86_64.yml
9fc8e1a 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_aarch64.yml
3d98a28 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_linux_x86_64.yml
adad503 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_mac.yml
205a54c 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_win.yml
8efee06 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby

This comment was marked as resolved.

Sign in to view
@justinchuby
Update release_linux_x86_64.yml
ab2d268 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_mac.yml
2ad3a71 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update release_win.yml
6D40 93ebe9f 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby marked this pull request as ready for review January 23, 2024 04:31
@justinchuby justinchuby enabled auto-merge January 23, 2024 04:31
@justinchuby justinchuby added this pull request to the merge queue Jan 23, 2024
Merged via the queue into onnx:main with commit 3a39b0b Jan 23, 2024
@johnnynunez johnnynunez mentioned this pull request Mar 6, 2024
Closed
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@isdanni @justinchuby @linshokaku
Support Python 3.12 (onnx#5743)
fb794de 
### Description
Close onnx#5680

### Motivation and Context
- Add Python 3.12 support.

---------

Signed-off-by: isdanni <leedanni@gmail.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
@andife andife mentioned this pull request Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees

@justinchuby justinchuby

Labels
run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages
Projects
PR Tracker
Status: Done
Milestone
1.16
Development

Successfully merging this pull request may close these issues.

[Feature request] Python 3.12 support
2 participants
@isdanni @justinchuby
0