8000 Incrementing version number to 1.6.0 by kevinch-nv · Pull Request #2353 · onnx/onnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Incrementing version number to 1.6.0 #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2019
Merged

Incrementing version number to 1.6.0 #2353

merged 2 commits into from
Sep 25, 2019

Conversation

kevinch-nv
Copy link
Contributor

No description provided.

@kevinch-nv kevinch-nv requested a review from a team as a code owner September 25, 2019 01:14
@CLAassistant
Copy link
CLAassistant commented Sep 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

wschin
wschin reviewed Sep 25, 2019
View reviewed changes
docs/Versioning.md Outdated
@@ -165,3 +165,4 @@ ONNX version|File format version|Operator set version ai.onnx|Operator set versi
1.3|3|8|1
1.4.1|4|9|1
1.5.0|5|10|1
1.6.0|6|11|1
Copy link
Contributor
@wschin wschin Sep 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.6.0|6|11|1
1.6.0|6|11|2

In ML domain, there is a LabelEncoder in opset 2.

If you find doing another CI build takes too long, I am ok with a post-release fix. This is just a documentation problem.

wschin
wschin approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor
@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small (but important) fix.

houseroad
houseroad approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member
@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinch-nv
Copy link
Contributor Author

@wschin looks like CI failed for one of the builds (https://travis-ci.org/onnx/onnx/jobs/589584006), perhaps a machine hang? Can this be wavied?

@prasanthpul
Copy link
Member

I've restarted that particular job.

@kevinch-nv kevinch-nv merged commit 553df22 into onnx:rel-1.6.0 Sep 25, 2019
kevinch-nv added a commit to kevinch-nv/onnx that referenced this pull request Oct 3, 2019
@kevinch-nv
Incrementing version number to 1.6.0 (onnx#2353)
fd461c0 
* Incrementing version number to 1.6.0

* Updating ML version to 2
kevinch-nv added a commit that referenced this pull request Oct 3, 2019
@kevinch-nv
Incrementing version number to 1.6.0 (#2353) (#2385)
9058d3a 8000 
* Incrementing version number to 1.6.0

* Updating ML version to 2
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
@kevinch-nv
Incrementing version number to 1.6.0 (onnx#2353) (onnx#2385)
1c354d9 
* Incrementing version number to 1.6.0

* Updating ML version to 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wschin wschin wschin approved these changes

@houseroad houseroad houseroad approved these changes

@ebarsoum ebarsoum Awaiting requested review from ebarsoum

@jspisak jspisak Awaiting requested review from jspisak

@linkerzhang linkerzhang Awaiting requested review from linkerzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinch-nv @CLAassistant @prasanthpul @wschin @houseroad
0