8000 Fix config contract prompt forcing alias by chasefleming · Pull Request #1913 · onflow/flow-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix config contract prompt forcing alias #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2025
Merged

Fix config contract prompt forcing alias #1913

merged 4 commits into from
Apr 1, 2025
+9 −24

Conversation

chasefleming
Copy link
Member
@chasefleming chasefleming commented Apr 1, 2025 •
edited
Loading

Closes #1911

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Bug The issue represents a bug, malfunction, regression label Apr 1, 2025
@codecov-commenter
Copy link
codecov-commenter commented Apr 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.26%. Comparing base (257acb3) to head (d844dcc).

Files with missing lines Patch % Lines
internal/prompt/prompt.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1913      +/-   ##
==========================================
+ Coverage   28.21%   28.26%   +0.04%     
==========================================
  Files          95       95              
  Lines        6602     6591      -11     
==========================================
  Hits         1863     1863              
+ Misses       4557     4546      -11     
  Partials      182      182
Flag Coverage Δ
unittests 28.26% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chasefleming chasefleming merged commit 7a7bb05 into master Apr 1, 2025
5 checks passed
@chasefleming chasefleming deleted the cf/fix-contract-prompt branch April 1, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbink jribbink jribbink approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

Assignees
No one assigned
Labels
Bug The issue represents a bug, malfunction, regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] flow config add contract forcing me to add an alias
3 participants
@chasefleming @codecov-commenter @jribbink
0