e2e workflow update #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding trivy within e2e workflow remonving trivy from PR trigger
mhmxs
reviewed
Apr 12, 2022
.github/workflows/trivy.yml
Outdated
| @@ -25,7 +23,7 @@ jobs: | |||
| - name: Run Trivy vulnerability scanner | |||
| uses: aquasecurity/trivy-action@2a2157eb22c08c9a1fac99263430307b8d1bc7a2 | |||
| with: | |||
| image-ref: ghcr.io/ondat/trousseau:${{ github.sha }}' | |||
| image-ref: ghcr.io/ondat/trousseau:latest' | |||
There was a problem hiding this comment.
Could you please describe why latest is the best to use here?
There was a problem hiding this comment.
I modified the trivy.yml for ondemand only as there is a dedicated definition for the e2e and I pointed to latest for that purpose.
Would you put instead?
There was a problem hiding this comment.
Nothing special, i just feel cold using latest, because some systems always pulls the latest from the repo
There was a problem hiding this comment.
since we have the trivy vulnerability scanning done for every PR, we can potentially remove this ondemand scan
mhmxs
previously approved these changes
Apr 12, 2022
mhmxs
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping the actions version
adding trivy within e2e workflow
remonving trivy from PR trigger