[DNM] Fix CodeQL reported vulnerabilities #2398
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kipchirchir Sigei <arapgodsmack@gmail.com>
Signed-off-by: Kipchirchir Sigei <arapgodsmack@gmail.com>
Signed-off-by: Kipchirchir Sigei <arapgodsmack@gmail.com>
Signed-off-by: Kipchirchir Sigei <arapgodsmack@gmail.com>
| new_filename = f"{basename}-{index}{ext}" | ||
| # check for an index i.e. dash then number then dot extension | ||
| regex = re.compile(r"(.+?)\-(\d+)(\..+)") | ||
| match = regex.match(filename) |
8600
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
| @@ -962,22 +962,22 @@ | |||
|
|
|||
| # Capture urls within form title | |||
| if re.search( | |||
| r"^(?:http(s)?:\/\/)?[\w.-]+(?:\.[\w\.-]+)+[\w\-\._~:/?#[\]@!\$&'\(\)\*\+,;=.]+$", # noqa | |||
| r"^(?:http(s)?:\/\/)?[\w\-.]+(?:\.[\w\-.]+)+[\w\-.~:/?#[\]@!\$&'()*+,;=]+$", # noqa | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Fixes the following Vulnerabilities
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #