feat: add shadows tokens to theme.tokens and documentation #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include shadows in theme contract (theme-contract.ts) - Add comprehensive shadows documentation page - Create ShadowTokens component for documentation - Add shadows to design tokens navigation - Update tokens.mdx with shadows example Closes omnifed#1386
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
caseybaggz
requested changes
Jun 25, 2025
| @@ -0,0 +1,55 @@ | |||
| 'use client' | |||
|
|
|||
| import { Box, Grid } from '@cerberus-design/react' | |||
There was a problem hiding this comment.
Great contribution! The React lib doesn't export the Box component, that instead should come from the local styled-system/jsx location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior (required)?
The shadows tokens exist in the codebase but are not accessible via
theme.tokens.shadows.This addresses issue #1386 which requests including shadows in the theme tokens.
What is the new behavior (required)?
theme.tokens.shadowsUsers can now:
theme.tokens.shadowsCloses #1386