Fix okteto preview deploy --log-output json command #4726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that the handlerPipelineLogLine function in pkg/okteto/stream.go was not setting the log stage before printing messages. When --log-output json is specified, the logs need to be formatted as JSON with the proper stage information. The fix sets the stage using oktetoLog.SetStage() before calling oktetoLog.Println(), ensuring that the JSON writer properly formats the output with stage information.
Signed-off-by: Javier Lopez <javier@okteto.com>
|
Hi @jvc5546, This has a downside. If you are deploying a repo with dependencies the messages will now appear in the main one as part of the |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4726 +/- ##
==========================================
- Coverage 48.86% 48.83% -0.03%
==========================================
Files 354 354
Lines 29718 29722 +4
==========================================
- Hits 14521 14515 -6
- Misses 14040 14048 +8
- Partials 1157 1159 +2 🚀 New features to boost your workflow:
|
|
@jvc5546 I'm going to close this PR given that we need to figure out how to do this without affecting other pipelines. Let me know if you have any concern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PROD-290 issue where the
okteto preview deploy --log-output jsondoesn't output anything.Okteto Agent Fleets generated text below here
The issue was that the handlerPipelineLogLine function in pkg/okteto/stream.go was not setting the log stage before printing messages. When --log-output json is specified, the logs need to be formatted as JSON with the proper stage information.
The fix sets the stage using oktetoLog.SetStage() before calling oktetoLog.Println(), ensuring that the JSON writer properly formats the output with stage information.
Proposed changes
Fixes # (issue)
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
How to validate
Please provide step-by-step instructions to replicate your validation scenario. For bug fixes, detail how to reproduce both the bug and its fix, along with any observations.
CLI Quality Reminders 🔧
For both authors and reviewers: