Option 2: add spinner forchecking services #4705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Lopez <javier@okteto.com>
…logging Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4705 +/- ##
==========================================
- Coverage 48.87% 48.85% -0.02%
==========================================
Files 354 354
Lines 29517 29522 +5
==========================================
- Hits 14425 14424 -1
- Misses 13948 13952 +4
- Partials 1144 1146 +2 🚀 New features to boost your workflow:
|
ifbyol
reviewed
Apr 22, 2025
There was a problem hiding this comment.
I think we will need to move the info message Okteto Smart Builds is skipping build of 'xxxx' because it's already built from cache to a bit later, just after we copy the image to the dev registry. If not, there is a moment where we say that the api image was skipped, but the spinner still shows that is checking if the api image was built.
Signed-off-by: Javier Lopez <javier@okteto.com>
ifbyol
approved these changes
Apr 22, 2025
Signed-off-by: Javier Lopez <javier@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes DEV-861
This PR has been created with cindy.
Adds a new spinner when is checking if a image has been built
How to validate
CLI Quality Reminders 🔧
For both authors and reviewers: