Implement use of OKTETO_DEV_PERSISTENT_VOLUME_SIZE #4580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltVolumeSize Signed-off-by: Teresa Romero <teresa@okteto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4580 +/- ##
=======================================
Coverage 48.07% 48.08%
=======================================
Files 369 369
Lines 29737 29741 +4
=======================================
+ Hits 14296 14300 +4
Misses 14324 14324
Partials 1117 1117
|
ifbyol
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves https://okteto.atlassian.net/browse/PROD-253
When assigning a volume size to the pvc running
okteto upthe default value is overriden by the env value if present.Default value is used when there is no definition of size at the manifest.
How to validate
Build binary, add the variable to admin variables at the cluster with a value.
Run okteto up and check the value is the one set by the env, different than the 5Gi default one
Run okteto up with a manifest that has a defined size, the pvc should be the one on the manifest.
Added unit test for the new cases.