DEV-510: Fix availability of CI env var on remote executions #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4545 +/- ##
=======================================
Coverage 46.16% 46.16%
=======================================
Files 355 355
Lines 28393 28393
=======================================
Hits 13109 13109
Misses 14173 14173
Partials 1111 1111 |
teresaromero
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
was curious and read about this here, in case helps someonelse undertand the issue https://vsupalov.com/docker-arg-env-variable-guide/
maroshii
approved these changes
Oct 30, 2024
jLopezbarb
approved these changes
Oct 30, 2024
pchico83
approved these changes
Oct 30, 2024
| @@ -86,7 +86,7 @@ WORKDIR /okteto/src | |||
| ENV {{$key}}={{$val}} | |||
| {{end}} | |||
| {{range $key, $val := .OktetoCommandSpecificEnvVars }} | |||
| ARG {{$key}} {{$val}} | |||
| ENV {{$key}}={{$val}} | |||
There was a problem hiding this comment.
ARG {{$key}}={{$val}} also works. The main difference between ARG and ENV is that you can change the value of ARG for different builds. Since we autogenerate these dockerfiles, instead of passing ARG values for the same dockerfile, both options are equivalent.
ifbyol
added a commit
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes DEV-510
Nicklas reported some time ago that the
CIenv var wasn't being propagated correctly to the test execution in remote. I was taking a look at it today as it also affected to env varOKTETO_IS_PREVIEW_ENVIRONMENT. After some testing, I saw that is related to usingARGinstead ofENV. I'm not sure why, but using ARG with default value is not making that env var available inremote-runcommand. The only way I had to make it available was:ENVinstead ofARGAs there is not final image built, which is the main difference between
ENVandARG(the availability of that var in the running container or not), I opted by switching it to useENVHow to validate
CIandOKTETO_IS_PREVIEW_ENVIRONMENT.export CI=trueandexport OKTETO_IS_PREVIEW_ENVIRONMENT=trueokteto test unitwith the CLI 3.0, you will see how nothing is printedCLI Quality Reminders 🔧
For both authors and reviewers: