8000 Fix postcss issues by mpourismaiel · Pull Request #816 · okkur/syna · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix postcss issues #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Disable postcss asset pipes by default, it requires postcss variable to be set to true in site's Params config.

Which issue this PR fixes:
fixes #813

Special notes for your reviewer:

Release note:

- Fix issue preventing site build when `postcss-cli` is not installed

@mpourismaiel mpourismaiel self-assigned this Aug 1, 2020
@stp-ip
Copy link
Member
stp-ip commented Aug 2, 2020

Rerunning the test.

@stp-ip
Copy link
Member
stp-ip commented Aug 2, 2020

Interesting. We are running into the issue we want to fix in the tests. Did you run the tests locally as well?

@mpourismaiel
Copy link
Member Author

I'm not really sure what's happening. Hugo builds and runs development server in all conditions. Production and development both work without postcss = true and they fail if postcss = true is set and postcss is not installed. But they will run with that parameter set, if postcss is installed.

In the test environment, cypress is not running since Hugo is failing and I can't figure out why that's happening. I'd appreciate any ideas or solutions.

@stp-ip
Copy link
Member
stp-ip commented Aug 5, 2020

Haven't figured out what's wrong here. Will take another stab at it once time permits.

@nzt-ventures nzt-ventures merged commit 9577538 into okkur:v0.17 Oct 23, 2020
@stp-ip stp-ip added this to the v0.17.4 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants
0