8000 Write tests for jq-helpers by mpourismaiel · Pull Request #791 · okkur/syna · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Write tests for jq-helpers #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 15, 2020

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Write tests for jq-helpers

Which issue this PR fixes:
fixes #790

Release note:

- Write more tests

@mpourismaiel mpourismaiel requested a review from stp-ip July 3, 2020 14:41
@mpourismaiel mpourismaiel self-assigned this Jul 3, 2020
@ghost
Copy link
ghost commented Jul 3, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.309 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@mpourismaiel
Copy link
Member Author

@stp-ip This seems like it's done. Let me know if you think we need other tests as well.

@stp-ip
Copy link
Member
stp-ip commented Jul 5, 2020

Will review asap. Great initiative.

< A88E div data-view-component="true" class="TimelineItem"> stp-ip
Copy link
Member
@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. More tests \o/
Took a bit longer JS is not my favorite ;)

@stp-ip stp-ip merged commit df44b2b into okkur:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Write tests for js helpers
2 participants
0