8000 Fix formspree not working when asking for captcha by mpourismaiel · Pull Request #689 · okkur/syna · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dismiss alert

Fix formspree not working when asking for captcha #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Formspree sometimes asks for captcha confirmation and form activation which is done with a 4xx status code and HTML response which can't be displayed in place. So this PR removes async behavior for formspree forms and redirects submission to their website.

Which issue this PR fixes:
fixes #613

Release note:

- contact: formspree forms now work synchronously 

@mpourismaiel mpourismaiel added this to the v0.16.1 milestone Jan 22, 2020
8000
@mpourismaiel mpourismaiel requested a review from stp-ip January 22, 2020 15:34
@mpourismaiel mpourismaiel self-assigned this Jan 22, 2020
@ghost
Copy link
ghost commented Jan 22, 2020

DeepCode's analysis on #5084f3 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

Copy link
Member
@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stp-ip stp-ip merged commit 429a736 into okkur:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Contact form gets 401 error
2 participants
0