Add basic support for multilingual #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #5a68c7 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
stp-ip
requested changes
Jan 16, 2020
stp-ip
requested changes
Jan 22, 2020
There was a problem hiding this comment.
A few small changes in the docs. The general working seems good.
Might have missed a few edge cases and need to do another manual test run with a multi lingual production page maybe txtdirect.
As mentioned a follow on PR with a /dev/ section and cypress tests would be good.
| but the portfolio fragment will be the translated version. The page will have | ||
| not changed for the default language. | ||
|
|
||
| > The Multilingual mode is in alpha mode. This means it is subject to change and |
There was a problem hiding this comment.
Suggested change
| > The Multilingual mode is in alpha mode. This means it is subject to change and | |
| > Multilingual mode is currently release as alpha. It is subject to changes and |
stp-ip
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds basic support for multilingual websites.
I'll add documentation and examples ASAP.
Which issue this PR fixes:
fixes #14
fixes #680
Special notes for your reviewer:
Release note: