8000 Add default page title by mpourismaiel · Pull Request #670 · okkur/syna · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add default page title #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2019
Merged

Add default page title #670

merged 1 commit into from
Dec 19, 2019

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Add default page title using title of the first content fragment found in
page.

Which issue this PR fixes:
fixes (partially) #655

Special notes for your reviewer:
This PR only adds default title to the page. Removing date metadata which was mentioned in the issue is not done and I don't think fixing it in the same PR is a good idea since the change is a bit complicated already.

Release note:

- page: Each page now uses the first content fragment's title as page title by default.

@mpourismaiel
Add default page title
1fe8e68 
This is done using title of the first content fragment found in
page.
@mpourismaiel mpourismaiel added this to the v0.16.0 milesto 8000 ne Dec 18, 2019
@mpourismaiel mpourismaiel requested a review from stp-ip December 18, 2019 15:08
@mpourismaiel mpourismaiel self-assigned this Dec 18, 2019
@ghost
Copy link
ghost commented Dec 18, 2019

DeepCode's analysis on #1fe8e6 found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

stp-ip
stp-ip approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member
@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a docs change in a follow on PR.

@stp-ip stp-ip merged commit 1f21cd6 into okkur:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stp-ip stp-ip stp-ip approved these changes

Assignees

@mpourismaiel mpourismaiel

Labels
enhancement
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mpourismaiel @stp-ip
0