8000 Remove all mentions of analytics by Inhishonor · Pull Request #483 · octoshrimpy/quik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove all mentions of analytics #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/PR-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,21 @@ jobs:

- name: Build APK
run: |
./gradlew assembleNoAnalyticsRelease \
./gradlew assembleRelease \
-Pandroid.injected.signing.store.file=${{ github.workspace }}/my-release-key.keystore \
-Pandroid.injected.signing.store.password=${{ secrets.KEYSTORE_PASSWORD }} \
-Pandroid.injected.signing.key.alias=${{ secrets.KEY_ALIAS }} \
-Pandroid.injected.signing.key.password=${{ secrets.KEY_PASSWORD }} \
--stacktrace

- name: Rename APK
run: mv presentation/build/outputs/apk/noAnalytics/release/QUIK-v*-noAnalytics-release.apk presentation/build/outputs/apk/noAnalytics/release/QUIK-noAnalytics-release.apk
run: mv presentation/build/outputs/apk/release/QUIK-v*-release.apk presentation/build/outputs/apk/release/QUIK-release.apk

- name: Upload APK
uses: actions/upload-artifact@v4
with:
name: apk
path: presentation/build/outputs/apk/noAnalytics/release/QUIK-noAnalytics-release.apk
path: presentation/build/outputs/apk/release/QUIK-release.apk

release:
name: validate fdroid APK
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-and-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,21 @@ jobs:

- name: Build APK
run: |
./gradlew assembleNoAnalyticsRelease \
./gradlew assembleRelease \
-Pandroid.injected.signing.store.file=${{ github.workspace }}/my-release-key.keystore \
-Pandroid.injected.signing.store.password=${{ secrets.KEYSTORE_PASSWORD }} \
-Pandroid.injected.signing.key.alias=${{ secrets.KEY_ALIAS }} \
-Pandroid.injected.signing.key.password=${{ secrets.KEY_PASSWORD }} \
--stacktrace

- name: Rename APK
run: mv presentation/build/outputs/apk/noAnalytics/release/QUIK-v*-noAnalytics-release.apk presentation/build/outputs/apk/noAnalytics/release/QUIK-noAnalytics-release.apk
run: mv presentation/build/outputs/apk/release/QUIK-v*-release.apk presentation/build/outputs/apk/release/QUIK-release.apk

- name: Upload APK
uses: actions/upload-artifact@v4
with:
name: apk
path: presentation/build/outputs/apk/noAnalytics/release/QUIK-noAnalytics-release.apk
path: presentation/build/outputs/apk/release/QUIK-release.apk

release:
name: Release APK
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
with:
prerelease: true
tag_name: "v${{ env.DATETIME }}"
files: QUIK-noAnalytics-release.apk
files: QUIK-release.apk
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-on-pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,20 @@ jobs:

- name: Build with Gradle
run: |
./gradlew assembleNoAnalyticsDebug \
./gradlew assembleDebug \
-Dandroid.injected.signing.store.file=${{ github.workspace }}/my-release-key.keystore

- name: Run Tests
run: ./gradlew test

- name: List APK Output Directory
run: ls -R presentation/build/outputs/apk/noAnalytics/debug
run: ls -R presentation/build/outputs/apk/debug

- name: Rename APK
run: mv presentation/build/outputs/apk/noAnalytics/debug/QUIK-v*-noAnalytics-debug.apk presentation/build/outputs/apk/noAnalytics/debug/QUIK-noAnalytics-debug.apk
run: mv presentation/build/outputs/apk/debug/QUIK-v*-debug.apk presentation/build/outputs/apk/debug/QUIK-debug.apk

- name: Upload App
uses: actions/upload-artifact@v4
with:
name: apk-debug
path: presentation/build/outputs/apk/noAnalytics/debug/QUIK-noAnalytics-debug.apk
path: presentation/build/outputs/apk/debug/QUIK-debug.apk
7 changes: 0 additions & 7 deletions data/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ apply plugin: 'kotlin-kapt'
android {
compileSdk 34
publishNonDefault true
flavorDimensions "analytics"

compileOptions {
sourceCompatibility 1.8
Expand All @@ -38,10 +37,6 @@ android {
buildConfigField "String", "AMPLITUDE_API_KEY", "\"${System.getenv("AMPLITUDE_API_KEY")}\""
}

productFlavors {
withAnalytics { dimension "analytics" }
noAnalytics { dimension "analytics" }
}
namespace 'dev.octoshrimpy.quik.data'
}

Expand Down Expand Up @@ -103,8 +98,6 @@ dependencies {
implementation project(':common')
implementation project(':domain')

withAnalyticsImplementation 'com.android.installreferrer:installreferrer:1.1'
withAnalyticsImplementation "com.amplitude:android-sdk:2.16.0"
}

repositories {
Expand Down
10 changes: 10 additions & 0 deletions data/src/main/java/com/moez/QKSMS/manager/ReferralManagerImpl.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package dev.octoshrimpy.quik.manager

import javax.inject.Inject

class ReferralManagerImpl @Inject constructor() : ReferralManager {

override suspend fun trackReferrer() {
}

}
4 changes: 0 additions & 4 deletions data/src/main/java/com/moez/QKSMS/mapper/RatingManagerImpl.kt
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@
package dev.octoshrimpy.quik.mapper

import com.f2prateek.rx.preferences2.RxSharedPreferences
import dev.octoshrimpy.quik.manager.AnalyticsManager
import dev.octoshrimpy.quik.manager.RatingManager
import io.reactivex.rxkotlin.Observables
import javax.inject.Inject

class RatingManagerImpl @Inject constructor(
rxPrefs: RxSharedPreferences,
private val analyticsManager: AnalyticsManager
) : RatingManager {

companion object {
Expand All @@ -50,12 +48,10 @@ class RatingManagerImpl @Inject constructor(
}

override fun rate() {
// analyticsManager.track("Clicked Rate")
rated.set(true)
}

override fun dismiss() {
// analyticsManager.track("Clicked Rate (Dismiss)")
dismissed.set(true)
}

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

4 changes: 1 addition & 3 deletions domain/src/main/java/com/moez/QKSMS/experiment/Experiment.kt
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@ package dev.octoshrimpy.quik.experiment

import android.content.Context
import android.preference.PreferenceManager
import dev.octoshrimpy.quik.manager.AnalyticsManager
import java.util.Locale
import java.util.Random

abstract class Experiment<T>(val context: Context, val analytics: AnalyticsManager) {
abstract class Experiment<T>(val context: Context) {

private val prefs by lazy { PreferenceManager.getDefaultSharedPreferences(context) }
private val prefKey: String
Expand All @@ -49,7 +48,6 @@ abstract class Experiment<T>(val context: Context, val analytics: AnalyticsManag

else -> { // Variant hasn't been set yet
variants[Random().nextInt(variants.size)].also { variant ->
analytics.setUserProperty("Experiment: $key", variant.key)
prefs.edit().putString(prefKey, variant.key).apply()
}.value
}
Expand Down
Loading
0