8000 Enable Android conversation features by Choucroute-melba · Pull Request #434 · octoshrimpy/quik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable Android conversation features #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Choucroute-melba
Copy link
Contributor

Hi, this is for #423

This PR add the necessary shortcuts to the system and to notifications so Android can enable it's conversation features for QUIK : notifications will be displayed on top, you can define priority convs and you can uses and android's default conversations widget.

I also added a Recipient.getThemedIcon function to get unified icons between notifications, launcher shortcuts and in app view.

This is also a first step for bubbles support, but some more work is needed.

Screenshot_20250421-002905_Trebuchet
Screenshot_20250421-003116_QUIK-Debug
Screenshot_20250421-005756_Trebuchet
Screenshot_20250421-005010_Trebuchet

@octoshrimpy
Copy link
Owner

Thank you so much! going over the code now

@octoshrimpy octoshrimpy merged commit 6263e7b into octoshrimpy:master Apr 23, 2025
2 checks passed
@gavine99
Copy link
Contributor

@octoshrimpy fyi, i had to revert the commits in this pr from my local build because it broke notifications for group mms. not sure about single recipient mms or sms - i haven't tested for those.

@octoshrimpy
Copy link
Owner

@octoshrimpy fyi, i had to revert the commits in this pr from my local build because it broke notifications for group mms. not sure about single recipient mms or sms - i haven't tested for those.

that's no good, I didn't have any problems when testing. I wonder what's up

@gavine99
Copy link
Contributor

a had a quick browse of the logcat and it seemed it was maybe feeding a null image to the notification when a new message arrived. the group mms had 1 recipient with an image associated, and 3 recipients with no image associated.

@Choucroute-melba
Copy link
Contributor Author

Hi, I made a fix in #445 that I tested in shortcuts but I couldn't test notifications so tell me if there is anything else I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0