8000 Backends: SDL2: don't try to capture mouse if we can't use global mouse state by vs49688 · Pull Request #8561 · ocornut/imgui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backends: SDL2: don't try to capture mouse if we can't use global mouse state #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Backends: SDL2: don't try to capture mouse if we can't use global mouse state #8561

wants to merge 1 commit into from

Conversation

vs49688
Copy link
Contributor
@vs49688 vs49688 commented Apr 9, 2025

Should be functionally identical, but prevents logspam generated by SDL_CaptureMouse() on Wayland.

e.g.

That operation is not supported
That operation is not supported
That operation is not supported
That operation is not supported
That operation is not supported
That operation is not supported
....
That operation is not supported
That operation is not supported

@vs49688 < DD8C /a>
Backends: SDL2: don't try to capture mouse if we can't use global mou…
b241cc5 
…se state

Should be functionally identical, but prevents logspam generated by
SDL_CaptureMouse() on Wayland.
@ocornut
Copy link
Owner
ocornut commented Apr 9, 2025

Hello, thanks for your PR.
Could you check if SDL3 backend has the same issue of logging/reporting that the operation is not supported?

@ocornut
Copy link
Owner
ocornut commented Apr 9, 2025

I have reworked this as 74e453c via another variable and applied to SDL2+SDL3.
I was tempted to make it a black-list instead of a white-list but we'll advise. Capturing mouse makes little sense on non-desktop platforms anyhow.

@ocornut ocornut closed this Apr 9, 2025
ocornut pushed a commit that referenced this pull request Apr 9, 2025
@vs49688 @ocornut
Backends: SDL2, SDL3: don't attempt to call SDL_CaptureMouse() on dri…
74e453c 
…vers where we don't call SDL_GetGlobalMouseState(). (#8561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backends inputs linux/bsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vs49688 @ocornut
0