Add additional ImGuiKey entry for the extra key on a non-US ISO keyboard, and add a case for it to the Win32 backend. #7206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard, and add a case for it to the Win32 backend. As ImGuiKey values are named after keys on a US keyboard, this key is not named after what's on its keycap - since US keyboards don't have it! (And the character this key produces in practice varies...) (cherry picked from commit 7decc97)
|
I am going to close this, seeing that according to https://docs.google.com/spreadsheets/d/1TwAHusBpxf_avmk03FUSrni17RP8qXmbJeDzs5fs0nY/edit#gid=0 we have many other things to tackle and they would be best tackled together. Additionally, afaik according to data we have (please confirm), VK_OEM_8 key referred to in this PR never correspond to a key that doesn't exist in physical US layout. It is also that the mapping of GraveAccent is confusing depending on layout. |
|
FYI pushed a9e5382 now. Will write details in other topics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ImGuiKey values are named after keys on a US keyboard, this key is not named after what's on its keycap - since US keyboards don't have it! (And the character this key produces in practice varies...)
See #7136