8000 fix(dlm): don't compare the table structure if syncTableStructure is off by guowl3 · Pull Request #3014 · oceanbase/odc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(dlm): don't compare the table structure if syncTableStructure is off #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix(dlm): don't compare the table structure if syncTableStructure is off #3014

merged 1 commit into from
Jul 25, 2024

Conversation

guowl3
Copy link
Collaborator
@guowl3 guowl3 commented Jul 25, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

  1. Don't compare the table structure if syncTableStructure is off.
  2. Sync table structure only supports MySQL and OMySQL. It throws an unsupported exception if other databases are chosen.

Which issue(s) this PR fixes:

Fixes #2844 #2845

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@guowl3 guowl3 added this to the ODC 4.3.1 milestone Jul 25, 2024
@guowl3 guowl3 self-assigned this Jul 25, 2024
@guowl3 guowl3 requested review from yhilmare and yizhouxw as code owners July 25, 2024 07:15
yizhouxw
yizhouxw approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor
@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yhilmare
yhilmare approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor
@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 743c034 into dev/4.3.x Jul 25, 2024
7 checks passed
@yhilmare yhilmare deleted the tianke_431_fix_sync_table_structure branch July 25, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhilmare yhilmare yhilmare approved these changes

@yizhouxw yizhouxw yizhouxw approved these changes

Assignees

@guowl3 guowl3

Labels
None yet
Projects
None yet
Milestone
ODC 4.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@guowl3 @yhilmare @yizhouxw
0