Count lines in all cases. #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainfrisch
reviewed
Jun 1, 2023
|
You need to update comments and doc-comments in the ml and MLI files. |
|
Sounds good I was sending this first to see if there was a consensus on the changes. I'll wrap this up, thanks! |
|
You can now rebase the PR and update doc-comments :) |
|
Yeah, it became pretty trivial after all 😅 |
|
LGTM modulo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to track this down: we are not counting position lines when parsing from a string.
Is there any reason for that? This seems pretty counter-intuitive and I imagine most users would trip on that, expecting lines to be counted properly in all cases.