8000 Fix directly nested sedlex matches by smuenzel · Pull Request #117 · ocaml-community/sedlex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix directly nested sedlex matches #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2023
Merged

Fix directly nested sedlex matches #117

merged 3 commits into from
Feb 17, 2023

Conversation

smuenzel
Copy link
Contributor

Currently, the code pattern

  match%sedlex lexbuf with
  ...
  | _ ->
    match%sedlex lexbuf with
    | _ ->

Does not compile, because the match subexpressions are transformed with super#expression rather than this#expression.

@hhugo
Copy link
Contributor
hhugo commented Feb 17, 2023

looks good

@hhugo
Copy link
Contributor
hhugo commented Feb 17, 2023

fix #12

@toots toots merged commit f30e450 into ocaml-community:master Feb 17, 2023
@toots
Copy link
Member
toots commented Feb 17, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alainfrisch alainfrisch Awaiting requested review from alainfrisch alainfrisch is a code owner

@Drup Drup Awaiting requested review from Drup Drup is a code owner

@pmetzger pmetzger Awaiting requested review from pmetzger pmetzger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuenzel @hhugo @toots
0