fix(melange): disallow private implementations of public virtual libs #11253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
324de2e to
7bb3cae
Compare
1666acf to
4fd42fc
Compare
|
@rgrinberg ping |
rgrinberg
approved these changes
Jan 4, 2025
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
4fd42fc to
e48ea86
Compare
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jan 22, 2025
…ocaml#11253) * test(melange): show wrong require for private impl of public virtual lib Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix(melange): disallow private implementations of public virtual libs Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * changelog Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jan 23, 2025
…ocaml#11253) * test(melange): show wrong require for private impl of public virtual lib Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix(melange): disallow private implementations of public virtual libs Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * changelog Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
maiste
pushed a commit
that referenced
this pull request
Jan 23, 2025
…blic virtual libs (#11372) * test(melange): show wrong require for private impl of public virtual lib * fix(melange): disallow private implementations of public virtual libs * changelog --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
ElectreAAS
pushed a commit
to ElectreAAS/dune
that referenced
this pull request
Jan 27, 2025
…ocaml#11253) * test(melange): show wrong require for private impl of public virtual lib Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix(melange): disallow private implementations of public virtual libs Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * changelog Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
chris-armstrong
pushed a commit
to chris-armstrong/dune
that referenced
this pull request
Jan 29, 2025
…ocaml#11253) * test(melange): show wrong require for private impl of public virtual lib Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix(melange): disallow private implementations of public virtual libs Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * changelog Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> Signed-off-by: Chris Armstrong <chris-armstrong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.