fix: stop using slang parser in regular dune files #9530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally used to parse run actions in regular dune files. This was problematic as the slang dsl is still experimental and intended for use in package management only at least for now. This change specializes the parser used for run actions so that the slang dsl parser is only used when parsing lockfiles. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
|
fixes #9529 |
rgrinberg
approved these changes
Dec 19, 2023
|
Yeh I'll definitely fix the bug with slang (though I'm starting to think it's a more general bug). Regardless, since slang is still quite experimental I don't think we should be exposing it to non-pkg yet. |
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Jan 5, 2024
This was accidentally used to parse run actions in regular dune files. This was problematic as the slang dsl is still experimental and intended for use in package management only at least for now. This change specializes the parser used for run actions so that the slang dsl parser is only used when parsing lockfiles. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Jan 5, 2024
This was accidentally used to parse run actions in regular dune files. This was problematic as the slang dsl is still experimental and intended for use in package management only at least for now. This change specializes the parser used for run actions so that the slang dsl parser is only used when parsing lockfiles. Signed-off-by: Stephen Sherratt <stephen 8000 @sherra.tt>
emillon
added a commit
that referenced
this pull request
Jan 5, 2024
* Add test for parse error when using run action (#9528) Signed-off-by: Stephen Sherratt <stephen@sherra.tt> * fix: stop using slang parser in regular dune files (#9530) This was accidentally used to parse run actions in regular dune files. This was problematic as the slang dsl is still experimental and intended for use in package management only at least for now. This change specializes the parser used for run actions so that the slang dsl parser is only used when parsing lockfiles. Signed-off-by: Stephen Sherratt <stephen@sherra.tt> * chore: add metadata (xref, changelog) for 9530 (#9634) Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Stephen Sherratt <stephen@sherra.tt> Signed-off-by: Etienne Millon <me@emillon.org> Co-authored-by: Stephen Sherratt <stephen@sherra.tt>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jan 5, 2024
CHANGES: - Fix version check in `runtest_alias` for `cram` stanza (ocaml/dune#9454, @emillon) - Fix stack overflow when a `(run)` action can not be parsed. (ocaml/dune#9530, fixes ocaml/dune#9529, @gridbugs)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Fix version check in `runtest_alias` for `cram` stanza (ocaml/dune#9454, @emillon) - Fix stack overflow when a `(run)` action can not be parsed. (ocaml/dune#9530, fixes ocaml/dune#9529, @gridbugs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally used to parse run actions in regular dune files. This was problematic as the slang dsl is still experimental and intended for use in package management only at least for now. This change specializes the parser used for run actions so that the slang dsl parser is only used when parsing lockfiles.