refactor: Resolve_names : extract a builder module #5762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `resolve_complex_deps` function contains a fold that manipulates a triplet to build a value of type `resolved_deps`. This extracts a module to extract that accumulator so that the logic of adding to it is separated from how to manipulate it. Signed-off-by: Etienne Millon <me@emillon.org>
|
This is in preparation for #5526. |
rgrinberg
requested changes
May 23, 2022
Signed-off-by: Etienne Millon <me@emillon.org>
rgrinberg
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resolve_complex_depsfunction contains a fold that manipulates a triplet to build a value of typeresolved_deps. This extracts a module to extract that accumulator so that the logic of adding to it is separated from how to manipulate it.