Lower OCaml version to 4.02.3 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2022
|
This sounds sensible, and you tested that it works on 4.02.3, so: merging. (This is optimistically assuming that the code did not break on versions later than 4.02.3 but before 4.05.0) |
|
Note: I guess this would benefit from a release, and I would be happy to let someone else do the release. Any volunteers? (Or maybe the opam metadata can be adjusted without re-releasing?) |
|
@gasche According to the CI it seems to build on everything between 4.02 and 4.13 so unless it compiles correctly but is subtly wrong it should probably be fine. I could imagine it builds on even older versions as well but if that is required I suggest it as an exercise to the reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Streamis going to be deprecated in OCaml 4.14 in Yojson to deal with this we wanted to switch to camlp-streams for now, until we get time to adjust the API. This would allow us to stay compatible for a while longer.But we support 4.02.3 as minimum version, so to avoid a complicated build headache of switching between the Stdlib-Stream and this Stream library it would be better if this library supported 4.02.3.
Given the code hasn't been touched in (probably) a long time it was my hunch that it should also build on older OCaml versions and, testing it on a 4.02.3 switch, that seems to have been correct.
Hence here's a PR to lower the minimum required OCaml version.