Bump leapp-framework to 2.1 #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding the recent changes, we provide new functionality regarding get_*_path() functions - so the shared/common paths that do not require execution of actors, can be used. This is useful e.g. when we want to get specific files for the purpose of commands. Previous use in actors is not affected by this change, however, use of these functions outside of actors (e.g. in leapp commands) requires the new implementation strictly. Fixes: 742
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
|
Can one of the admins verify this patch? |
pirat89
added a commit
to pirat89/leapp-repository
that referenced
this pull request
Dec 22, 2021
Changes in commands introduced in oamg#753 requires up-to-date changes in the leapp itself. Installing older builds of leapp makes the current implementation malfunction. Update of requirements fixes the problem. Relates: oamg#753 Requires: oamg/leapp#746
vinzenz
approved these changes
Dec 22, 2021
pirat89
added a commit
to oamg/leapp-repository
that referenced
this pull request
Jan 3, 2022
Changes in commands introduced in #753 requires up-to-date changes in the leapp itself. Installing older builds of leapp makes the current implementation malfunction. Update of requirements fixes the problem. Relates: #753 Requires: oamg/leapp#746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the recent changes, we provide new functionality regarding
get_*_path() functions - so the shared/common paths that do not
require execution of actors, can be used. This is useful e.g. when
we want to get specific files for the purpose of commands. Previous
use in actors is not affected by this change, however, use of these
functions outside of actors (e.g. in leapp commands) requires the
new implementation strictly.
Fixes: #742
Relates: oamg/leapp-repository#753