8000 Add cli support for choices and default by fernflower · Pull Request #734 · oamg/leapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add cli support for choices and default #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

Add cli support for choices and default #734

merged 1 commit into from
Oct 5, 2021

Conversation

fernflower
Copy link
Member

Extending leapp command to support traditional argparse-style choices
and default arguments.

@fernflower
Add cli support for choices and default
f9b2214 
Extending leapp command to support traditional argparse-style choices
and default arguments.
@github-actions
Copy link
github-actions bot commented Oct 4, 2021

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run copr build and e2e tests in OAMG CI
  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

vinzenz
vinzenz approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member
@vinzenz vinzenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link
github-actions bot commented Oct 4, 2021

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2872807

@github-actions
Copy link
github-actions bot commented Oct 4, 2021

Testing Farm request for tmt test was created. Once finished, results should be available here.
Full pipeline log.

@MichalHe MichalHe mentioned this pull request Oct 4, 2021
Merged
3 tasks
@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link
github-actions bot commented Oct 4, 2021

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2873199

@github-actions
Copy link
github-actions bot commented Oct 4, 2021

Testing Farm request for tmt test was created. Once finished, results should be available here.
Full pipeline log.

@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link
github-actions bot commented Oct 5, 2021

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2874643

@github-actions
Copy link
github-actions bot commented Oct 5, 2021

Testing Farm request for tmt test was created. Once finished, results should be available here.
Full pipeline log.

@pirat89 pirat89 merged commit 40128d4 into oamg:master Oct 5, 2021
@pirat89
Copy link
Member
pirat89 commented Oct 19, 2021 •
edited
Loading

@fernflower i just realized too late that with this change the leapp-framework capability had to be bumped to 2.1 to prevent various issues based on installed packages. But it's already too late and it doesn't make sense to bump it now when it's already livving for a time, but we should keep it in our minds in future that such changes has to be now reflected as well in this way.

pirat89 added a commit to pirat89/leapp that referenced this pull request Oct 19, 2021
@pirat89
Release 0.13.0
c0f7931 
## Packaging
- Drop the dependency on leapp-repository for Fedora and RHEL 8+ (oamg#717)
- Provide builds for RHEL 7+ and Fedora (oamg#717)
- Drop automatically generated Python dependences on RHEL 8+ and Fedora systems (oamg#717, oamg#716)
- Bump the provided leapp-framework capability to 2.0 (oamg#700)

## Framework
### Fixes
- models: Do not make references to private symbols (oamg#718)

### Enhancements
- Introduce the LEAPP_DEVEL_DATABASE_SYNC_OFF envar to enable speed up writes into the leapp database by disabling synchronisation - only for development / testing purposes (oamg#732)

## Leapp
### Fixes
- Fix print of the leapp help msg for Python 3.6+ (oamg#731)

### Enhancements
- The leapp commands are now defined/provided by leapp-repositories; leapp discovers the specified commands automatically (oamg#700)
- Add CLI support for `choices` and `default` for options of leapp commands (oamg#734)

## Modifications
- Makefile: Added the `fast_lint` target to apply linters just on files different from master (oamg#733)
@pirat89 pirat89 mentioned this pull request Oct 19, 2021
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Oct 19, 2021
@pirat89
Release 0.13.0
4e61095 
## Packaging
- Drop the dependency on leapp-repository for Fedora and RHEL 8+ (oamg#717)
- Provide builds for RHEL 7+ and Fedora (oamg#717)
- Drop automatically generated Python dependences on RHEL 8+ and Fedora systems (oamg#717, oamg#716)
- Bump the provided leapp-framework capability to 2.0 (oamg#700)

## Framework
### Fixes
- models: Do not make references to private symbols (oamg#718)

### Enhancements
- Introduce the LEAPP_DEVEL_DATABASE_SYNC_OFF envar to enable speed up writes into the leapp database by disabling synchronisation - only for development / testing purposes (oamg#732)

## Leapp
### Fixes
- Fix print of the leapp help msg for Python 3.6+ (oamg#731)

### Enhancements
- The leapp commands are now defined/provided by leapp-repositories; leapp discovers the specified commands automatically (oamg#700)
- Add CLI support for `choices` and `default` for options of leapp commands (oamg#734)

## Modifications
- Makefile: Added the `fast_lint` target to apply linters just on files different from master (oamg#733)
pirat89 added a commit that referenced this pull request Oct 19, 2021
@pirat89
Release 0.13.0
ca6ae67 
## Packaging
- Drop the dependency on leapp-repository for Fedora and RHEL 8+ (#717)
- Provide builds for RHEL 7+ and Fedora (#717)
- Drop automatically generated Python dependences on RHEL 8+ and Fedora systems (#717, #716)
- Bump the provided leapp-framework capability to 2.0 (#700)

## Framework
### Fixes
- models: Do not make references to private symbols (#718)

### Enhancements
- Introduce the LEAPP_DEVEL_DATABASE_SYNC_OFF envar to enable speed up writes into the leapp database by disabling synchronisation - only for development / testing purposes (#732)

## Leapp
### Fixes
- Fix print of the leapp help msg for Python 3.6+ (#731)

### Enhancements
- The leapp commands are now defined/provided by leapp-repositories; leapp discovers the specified commands automatically (#700)
- Add CLI support for `choices` and `default` for options of leapp commands (#734)

## Modifications
- Makefile: Added the `fast_lint` target to apply linters just on files different from master (#733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzenz vinzenz vinzenz approved these changes

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernflower @centos-ci @pirat89 @vinzenz
0