relax Debug impls to only require T::Key<'a>: Debug for a particular 'a #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
added a commit
that referenced
this pull request
Jun 6, 2025
Like in #39, we shouldn't require `Hash` on every `'k`, just on the relevant `'a`. The included test code would fail to compile without this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
Debugwith borrowed items to work in more circumstances.We do have to use unsafe code, but that's okay because we have a
T: 'abound. This means that the key is valid for 'a, and in any case we discard the key immediately after calling itsDebugimpl.It looks like we'll also have to do this for all the
IdOrdMapmutable getters. That will come in the future.