8000 parallelize android build much better by majestrate · Pull Request #1811 · oxen-io/lokinet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

parallelize android build much better #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2021
Merged

parallelize android build much better #1811

merged 1 commit into from
Nov 23, 2021

Conversation

majestrate
Copy link
Contributor
  • split up configure step and build step so that build steps goes all at once
  • update ci to use new build structure for android

@majestrate
paralellize android build much better
8c6bf31 
* split up configure step and build step so that build steps goes all at once
* update ci to use new build structure for android
@majestrate majestrate requested a review from jagerman November 23, 2021 17:48
@jagerman
Copy link
Member

What if we split this up into 4 separate CI pipelines, i.e. one for each arch? Given that we're now working from a base-already-installed CI image that ought to parallelize it better still (i.e. across machines) without adding much overhead on the individual jobs.

@jagerman
Copy link
Member

Oh, never mind, this is building a multi-arch apk, isn't it?

@majestrate
Copy link
Contributor Author

ABIS=x86 ./contrib/android.sh should do it given you want to build x86 only

jagerman
jagerman reviewed Nov 23, 2021
View reviewed changes
contrib/android-configure.sh
set -e 8000
set +x

default_abis="armeabi-v7a arm64-v8a x86 x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably drop x86 from this. ISTR there were some issues with it on the wallet, and so we dropped it and no one noticed because there is virtual no x86 android hardware in the wild.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason i am doing this cleanup is in preparation for potentially doing fdroid packaging. i do not know what the fdroid platforms that are supported

@majestrate
Copy link
Contributor Author

sid clang broke and idk why

@majestrate
Copy link
Contributor Author

json header library broken on clang 13 sid, amazin

@jagerman
Copy link
Member

json header library broken on clang 13 sid, amazin

It's not json that broke things, that looks like clang-13 + libstdc++-11 incompatibility in the header.

@jagerman
Copy link
Member

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000398

@jagerman
Copy link
Member 
hades:~$ cat foo.cpp 
#include <valarray>
int main() {}

hades:~$ clang++-13 -std=c++17 foo.cpp 
In file included from foo.cpp:1:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1215:5: error: exception specification in declaration does not match previous declaration
    begin(valarray<_Tp>& __va) noexcept
    ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/range_access.h:107:31: note: previous declaration is here
  template<typename _Tp> _Tp* begin(valarray<_Tp>&);
                              ^
In file included from foo.cpp:1:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1226:5: error: exception specification in declaration does not match previous declaration
    begin(const valarray<_Tp>& __va) noexcept
    ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/range_access.h:108:37: note: previous declaration is here
  template<typename _Tp> const _Tp* begin(const valarray<_Tp>&);
                                    ^
In file included from foo.cpp:1:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1237:5: error: exception specification in declaration does not match previous declaration
    end(valarray<_Tp>& __va) noexcept
    ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/range_access.h:109:31: note: previous declaration is here
  template<typename _Tp> _Tp* end(valarray<_Tp>&);
                              ^
In file included from foo.cpp:1:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1253:5: error: exception specification in declaration does not matc
8000
h previous declaration
    end(const valarray<_Tp>& __va) noexcept
    ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/range_access.h:110:37: note: previous declaration is here
  template<typename _Tp> const _Tp* end(const valarray<_Tp>&);
                                    ^
4 errors generated.

@majestrate majestrate merged commit d7529da into oxen-io:dev Nov 23, 2021
@majestrate majestrate deleted the android-ci-optimize-2021-11-23 branch April 18, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagerman jagerman jagerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majestrate @jagerman
0