8000 test(minifier): fail tests when parse fails by sapphi-red · Pull Request #8836 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test(minifier): fail tests when parse fails #8836

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2025
Merged

test(minifier): fail tests when parse fails #8836

merged 1 commit into from
Feb 2, 2025

Conversation

sapphi-red
Copy link
Member

No description provided.

@sapphi-red Graphite App
Copy link
Member Author
sapphi-red commented Feb 2, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 2, 2025
Merged
Merged
@github-actions github-actions bot added the A-minifier Area - Minifier label Feb 2, 2025
@sapphi-red sapphi-red marked this pull request as ready for review February 2, 2025 07:33
@sapphi-red sapphi-red changed the title tests(minifier): fail tests when parse fails test(minifier): fail tests when parse fails Feb 2, 2025
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Feb 2, 2025
@sapphi-red sapphi-red changed the base branch from 02-02-chore_minifier_correct_links_to_esbuild to graphite-base/8836 February 2, 2025 07:38
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Feb 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8836 will not alter performance

Comparing 02-02-tests_minifier_fail_tests_when_parse_fails (dc4c388) with main (0928a19)

Summary

✅ 33 untouched benchmarks

@sapphi-red sapphi-red force-pushed the 02-02-tests_minifier_fail_tests_when_parse_fails branch from e81be88 to 25c9f8a Compare February 2, 2025 07:43
@sapphi-red sapphi-red changed the base branch from graphite-base/8836 to main February 2, 2025 07:44
@sapphi-red sapphi-red force-pushed the 02-02-tests_minifier_fail_tests_when_parse_fails branch 2 times, most recently from 716ff90 to 5e109a8 Compare February 2, 2025 07:49
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 2, 2025
@Boshen Graphite App
Copy link
Member
Boshen commented Feb 2, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 2, 3:43 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 2, 3:43 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 2, 3:52 AM EST: A user merged this pull request with the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Feb 2, 2025
@sapphi-red
test(minifier): fail tests when parse fails (#8836)
9b78be7
@graphite-app graphite-app bot force-pushed the 02-02-tests_minifier_fail_tests_when_parse_fails branch from 5e109a8 to 9b78be7 Compare February 2, 2025 08:43
@graphite-app graphite-app bot force-pushed the 02-02-tests_minifier_fail_tests_when_parse_fails branch from 9b78be7 to dc4c388 Compare February 2, 2025 08:45
@graphite-app graphite-app bot merged commit dc4c388 into main Feb 2, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-02-tests_minifier_fail_tests_when_parse_fails branch February 2, 2025 08:52
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @Boshen
0