8000
refactor(ast/estree): add
github-actions
bot
added
A-ast
Area - AST
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
labels
Jun 18, 2025
graphite-app
bot
force-pushed
the
06-18-refactor_ast_estree_add_estree_attrs_to_regexpflagsalias_
branch
from
June 18, 2025 13:02
graphite-app
bot
deleted the
06-18-refactor_ast_estree_add_estree_attrs_to_regexpflagsalias_
branch
June 18, 2025 13:08
refactor(ast/estree): add #[estree] attrs to RegExpFlagsAlias
#11794
+4
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #11794 will not alter performanceComparing Summary
|
…1794) Pure refactor. Add more `#[estree]` attributes to `RegExpFlagsAlias` type. These have no effect on generated code for JSON serialization or raw transfer deserialization, as `RegExpFlagsAlias` already has a custom converter. But it simplifies the codegen for lazy deserialization.
a37369f to
08e666f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Add more
#[estree]attributes toRegExpFlagsAliastype. These have no effect on generated code for JSON serialization or raw transfer deserialization, asRegExpFlagsAliasalready has a custom converter. But it simplifies the codegen for lazy deserialization.